trustchain-oc1-orchestral/authentik
Archived
10
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

policies/event_matcher: fix empty app label not being allowed, require at least 1 criteria

Browse source 
closes #4643

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
This commit is contained in:
Jens Langhammer 2023-02-08 23:29:59 +01:00
parent 6a64d6b536
commit 1be792fbd8
No known key found for this signature in database
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
authentik/policies/event_matcher/api.py
View file

@ -1,5 +1,6 @@
"""Event Matcher Policy API""" """Event Matcher Policy API"""
from django.utils.translation import gettext as _ from django.utils.translation import gettext as _
from rest_framework.exceptions import ValidationError
from rest_framework.fields import ChoiceField from rest_framework.fields import ChoiceField
from rest_framework.viewsets import ModelViewSet from rest_framework.viewsets import ModelViewSet
@ -14,12 +15,18 @@ class EventMatcherPolicySerializer(PolicySerializer):
app = ChoiceField( app = ChoiceField(
choices=app_choices(), choices=app_choices(),
required=False, required=False,
allow_blank=True,
help_text=_( help_text=_(
"Match events created by selected application. When left empty, " "Match events created by selected application. When left empty, "
"all applications are matched." "all applications are matched."
), ),
) )
def validate(self, attrs: dict) -> dict:
if attrs["action"] == "" and attrs["client_ip"] == "" and attrs["app"] == "":
raise ValidationError(_("At least one criteria must be set."))
return super().validate(attrs)
class Meta: class Meta:
model = EventMatcherPolicy model = EventMatcherPolicy
fields = PolicySerializer.Meta.fields + [ fields = PolicySerializer.Meta.fields + [