From 85121de9d7c1a24ff9b9fa367158f3c88ae4819d Mon Sep 17 00:00:00 2001
From: Jens Langhammer <jens.langhammer@beryju.org>
Date: Sun, 4 Apr 2021 20:11:57 +0200
Subject: [PATCH] web/admin: only set ?writeOnly when editing an object

Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
---
 web/src/elements/forms/HorizontalFormElement.ts  | 2 +-
 web/src/pages/crypto/CertificateKeyPairForm.ts   | 4 ++--
 web/src/pages/sources/ldap/LDAPSourceForm.ts     | 2 +-
 web/src/pages/stages/captcha/CaptchaStageForm.ts | 2 +-
 web/src/pages/stages/email/EmailStageForm.ts     | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/web/src/elements/forms/HorizontalFormElement.ts b/web/src/elements/forms/HorizontalFormElement.ts
index 17e66b99d..ef3af1d0e 100644
--- a/web/src/elements/forms/HorizontalFormElement.ts
+++ b/web/src/elements/forms/HorizontalFormElement.ts
@@ -60,7 +60,7 @@ export class HorizontalFormElement extends LitElement {
             if (this.writeOnly && !this.writeOnlyActivated) {
                 const i = (input as HTMLInputElement);
                 i.setAttribute("hidden", "true");
-                const handler = (ev: Event) => {
+                const handler = () => {
                     i.removeAttribute("hidden");
                     this.writeOnlyActivated = true;
                     i.parentElement?.removeEventListener("click", handler);
diff --git a/web/src/pages/crypto/CertificateKeyPairForm.ts b/web/src/pages/crypto/CertificateKeyPairForm.ts
index c59f4b8b5..20fc398eb 100644
--- a/web/src/pages/crypto/CertificateKeyPairForm.ts
+++ b/web/src/pages/crypto/CertificateKeyPairForm.ts
@@ -48,14 +48,14 @@ export class CertificateKeyPairForm extends Form<CertificateKeyPair> {
             <ak-form-element-horizontal
                 label=${t`Certificate`}
                 name="certificateData"
-                ?writeOnly=${true}
+                ?writeOnly=${this.keyPair !== undefined}
                 ?required=${true}>
                 <textarea class="pf-c-form-control" required>${ifDefined(this.keyPair?.certificateData)}</textarea>
                 <p class="pf-c-form__helper-text">${t`PEM-encoded Certificate data.`}</p>
             </ak-form-element-horizontal>
             <ak-form-element-horizontal
                 name="keyData"
-                ?writeOnly=${true}
+                ?writeOnly=${this.keyPair !== undefined}
                 label=${t`Private Key`}>
                 <textarea class="pf-c-form-control" >${ifDefined(this.keyPair?.keyData)}</textarea>
                 <p class="pf-c-form__helper-text">${t`Optional Private Key. If this is set, you can use this keypair for encryption.`}</p>
diff --git a/web/src/pages/sources/ldap/LDAPSourceForm.ts b/web/src/pages/sources/ldap/LDAPSourceForm.ts
index 7f416da71..9f1815672 100644
--- a/web/src/pages/sources/ldap/LDAPSourceForm.ts
+++ b/web/src/pages/sources/ldap/LDAPSourceForm.ts
@@ -119,7 +119,7 @@ export class LDAPSourceForm extends Form<LDAPSource> {
                     <ak-form-element-horizontal
                         label=${t`Bind Password`}
                         ?required=${true}
-                        ?writeOnly=${true}
+                        ?writeOnly=${this.source !== undefined}
                         name="bindPassword">
                         <input type="text" value="${ifDefined(this.source?.bindPassword)}" class="pf-c-form-control" required>
                     </ak-form-element-horizontal>
diff --git a/web/src/pages/stages/captcha/CaptchaStageForm.ts b/web/src/pages/stages/captcha/CaptchaStageForm.ts
index d9a1ec4fe..3da01e454 100644
--- a/web/src/pages/stages/captcha/CaptchaStageForm.ts
+++ b/web/src/pages/stages/captcha/CaptchaStageForm.ts
@@ -66,7 +66,7 @@ export class CaptchaStageForm extends Form<CaptchaStage> {
                     <ak-form-element-horizontal
                         label=${t`Private Key`}
                         ?required=${true}
-                        ?writeOnly=${true}
+                        ?writeOnly=${this.stage !== undefined}
                         name="privateKey">
                         <input type="text" value="${ifDefined(this.stage?.privateKey || "")}" class="pf-c-form-control" required>
                         <p class="pf-c-form__helper-text">${t`Private key, acquired from https://www.google.com/recaptcha/intro/v3.html.`}</p>
diff --git a/web/src/pages/stages/email/EmailStageForm.ts b/web/src/pages/stages/email/EmailStageForm.ts
index 63d4d7f9a..431aed7d3 100644
--- a/web/src/pages/stages/email/EmailStageForm.ts
+++ b/web/src/pages/stages/email/EmailStageForm.ts
@@ -78,7 +78,7 @@ export class EmailStageForm extends Form<EmailStage> {
                     <ak-form-element-horizontal
                         label=${t`SMTP Password`}
                         ?required=${true}
-                        ?writeOnly=${true}
+                        ?writeOnly=${this.stage !== undefined}
                         name="password">
                         <input type="text" value="${ifDefined(this.stage?.password || "")}" class="pf-c-form-control" required>
                     </ak-form-element-horizontal>