policies: only cache policies for authenticated users

closes #4033

Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
This commit is contained in:
Jens Langhammer 2022-11-18 21:06:53 +01:00
parent c158ef80db
commit cc3ab141e5
2 changed files with 10 additions and 1 deletions

View file

@ -103,7 +103,7 @@ class PolicyProcess(PROCESS_CLASS):
LOGGER.debug("P_ENG(proc): error", exc=src_exc) LOGGER.debug("P_ENG(proc): error", exc=src_exc)
policy_result = PolicyResult(False, str(src_exc)) policy_result = PolicyResult(False, str(src_exc))
policy_result.source_binding = self.binding policy_result.source_binding = self.binding
if not self.request.debug: if self.request.should_cache:
key = cache_key(self.binding, self.request) key = cache_key(self.binding, self.request)
cache.set(key, policy_result, CACHE_TIMEOUT) cache.set(key, policy_result, CACHE_TIMEOUT)
LOGGER.debug( LOGGER.debug(

View file

@ -46,6 +46,15 @@ class PolicyRequest:
return return
self.context["geoip"] = GEOIP_READER.city(client_ip) self.context["geoip"] = GEOIP_READER.city(client_ip)
@property
def should_cache(self) -> bool:
"""Check if this request's result should be cached"""
if not self.user.is_authenticated:
return False
if self.debug:
return False
return True
def __repr__(self) -> str: def __repr__(self) -> str:
return self.__str__() return self.__str__()