From d35f524865bb789400af5b8156c42e8341bba950 Mon Sep 17 00:00:00 2001
From: Jens Langhammer <jens.langhammer@beryju.org>
Date: Sun, 21 Feb 2021 14:56:03 +0100
Subject: [PATCH] core: remove old templates

---
 authentik/core/templates/library.html         |  53 ----------
 .../core/templates/partials/pagination.html   |  42 --------
 .../templates/partials/toolbar_search.html    |  13 ---
 authentik/core/templates/user/token_list.html | 100 ------------------
 authentik/core/urls.py                        |   4 +-
 authentik/core/views/library.py               |  23 ----
 authentik/flows/stage.py                      |   3 +-
 authentik/stages/identification/tests.py      |   4 +-
 .../stages/autosubmit/AutosubmitStage.ts      |   2 +-
 9 files changed, 6 insertions(+), 238 deletions(-)
 delete mode 100644 authentik/core/templates/library.html
 delete mode 100644 authentik/core/templates/partials/pagination.html
 delete mode 100644 authentik/core/templates/partials/toolbar_search.html
 delete mode 100644 authentik/core/templates/user/token_list.html
 delete mode 100644 authentik/core/views/library.py

diff --git a/authentik/core/templates/library.html b/authentik/core/templates/library.html
deleted file mode 100644
index fa69e07a9..000000000
--- a/authentik/core/templates/library.html
+++ /dev/null
@@ -1,53 +0,0 @@
-{% load i18n %}
-
-<main role="main" class="pf-c-page__main" tabindex="-1" id="main-content">
-    <section class="pf-c-page__main-section pf-m-light">
-        <div class="pf-c-content">
-            <h1>
-                <i class="pf-icon pf-icon-applications"></i>
-                {% trans 'Applications' %}
-            </h1>
-        </div>
-    </section>
-    <section class="pf-c-page__main-section">
-        {% if applications %}
-        <div class="pf-l-gallery pf-m-gutter">
-            {% for app in applications %}
-            <a href="{{ app.get_launch_url }}" class="pf-c-card pf-m-hoverable pf-m-compact ak-root-link">
-                <div class="pf-c-card__header">
-                    {% if app.meta_icon %}
-                    <img class="app-icon pf-c-avatar" src="{{ app.meta_icon.url }}" alt="{% trans 'Application Icon' %}">
-                    {% else %}
-                    <i class="pf-icon pf-icon-arrow"></i>
-                    {% endif %}
-                </div>
-                <div class="pf-c-card__title">
-                    <p id="card-1-check-label">{{ app.name }}</p>
-                    <div class="pf-c-content">
-                        <small>{{ app.meta_publisher }}</small>
-                    </div>
-                </div>
-                <div class="pf-c-card__body">
-                    {% trans app.meta_description|truncatewords:35 %}
-                </div>
-            </a>
-            {% endfor %}
-        </div>
-        {% else %}
-        <div class="pf-c-empty-state pf-m-full-height">
-            <div class="pf-c-empty-state__content">
-                <i class="fas fa-cubes pf-c-empty-state__icon" aria-hidden="true"></i>
-                <h1 class="pf-c-title pf-m-lg">{% trans 'No Applications available.' %}</h1>
-                <div class="pf-c-empty-state__body">
-                    {% trans "Either no applications are defined, or you don't have access to any." %}
-                </div>
-                {% if perms.authentik_core.add_application %}
-                <a href="{% url 'authentik_admin:application-create' %}" class="pf-c-button pf-m-primary" type="button">
-                    {% trans 'Create Application' %}
-                </a>
-                {% endif %}
-            </div>
-        </div>
-        {% endif %}
-    </section>
-</main>
diff --git a/authentik/core/templates/partials/pagination.html b/authentik/core/templates/partials/pagination.html
deleted file mode 100644
index 87c2ae354..000000000
--- a/authentik/core/templates/partials/pagination.html
+++ /dev/null
@@ -1,42 +0,0 @@
-{% load i18n %}
-{% load authentik_utils %}
-
-<div class="pf-c-toolbar__item pf-m-pagination ">
-    <div class="pf-c-pagination pf-m-compact pf-m-hidden pf-m-visible-on-md">
-        <div class="pf-c-pagination pf-m-compact pf-m-compact pf-m-hidden pf-m-visible-on-md">
-            <div class="pf-c-options-menu">
-                <div class="pf-c-options-menu__toggle pf-m-text pf-m-plain">
-                    <span class="pf-c-options-menu__toggle-text">
-                        {% blocktrans with start_index=page_obj.start_index end_index=page_obj.end_index total_items=paginator.count %}
-                            {{ start_index }} - {{ end_index }} of {{ total_items }}
-                        {% endblocktrans %}
-                    </span>
-                </div>
-            </div>
-            <nav class="pf-c-pagination__nav" aria-label="Pagination">
-                <div class="pf-c-pagination__nav-control pf-m-prev">
-                    <a class="pf-c-button pf-m-plain"
-                        {% if page_obj.has_previous %}
-                        href="{{ request.path }}?{% query_transform page=page_obj.previous_page_number %}"
-                        {% else %}
-                        disabled
-                        {% endif %}
-                        aria-label="{% trans 'Go to previous page' %}">
-                        <i class="fas fa-angle-left" aria-hidden="true"></i>
-                    </a>
-                </div>
-                <div class="pf-c-pagination__nav-control pf-m-next">
-                    <a class="pf-c-button pf-m-plain"
-                        {% if page_obj.has_next %}
-                        href="{{ request.path }}?{% query_transform page=page_obj.next_page_number %}"
-                        {% else %}
-                        disabled
-                        {% endif %}
-                        aria-label="{% trans 'Go to next page' %}">
-                        <i class="fas fa-angle-right" aria-hidden="true"></i>
-                    </a>
-                </div>
-            </nav>
-        </div>
-    </div>
-</div>
diff --git a/authentik/core/templates/partials/toolbar_search.html b/authentik/core/templates/partials/toolbar_search.html
deleted file mode 100644
index aac4c9f30..000000000
--- a/authentik/core/templates/partials/toolbar_search.html
+++ /dev/null
@@ -1,13 +0,0 @@
-
-<div class="pf-c-toolbar__group pf-m-filter-group">
-    <div class="pf-c-toolbar__item pf-m-search-filter">
-        <form class="pf-c-input-group" method="GET">
-            {# include page data for pagination #}
-            <input type="hidden" name="page" value="{{ page_obj.number }}">
-            <input class="pf-c-form-control" name="search" type="search" placeholder="Search..." value="{{ request.GET.search }}">
-            <button class="pf-c-button pf-m-control" type="submit">
-                <i class="fas fa-search" aria-hidden="true"></i>
-            </button>
-        </form>
-    </div>
-</div>
diff --git a/authentik/core/templates/user/token_list.html b/authentik/core/templates/user/token_list.html
deleted file mode 100644
index c51b6b760..000000000
--- a/authentik/core/templates/user/token_list.html
+++ /dev/null
@@ -1,100 +0,0 @@
-{% load i18n %}
-
-<div class="pf-c-card">
-    <div class="pf-c-card__header pf-c-title pf-m-md">
-        <p>{% trans "Tokens can be used to access authentik's API." %}</p>
-    </div>
-    {% if object_list %}
-    <div class="pf-c-toolbar">
-        <div class="pf-c-toolbar__content">
-            {% include 'partials/toolbar_search.html' %}
-            <div class="pf-c-toolbar__bulk-select">
-                <ak-modal-button href="{% url 'authentik_core:user-tokens-create' %}">
-                    <ak-spinner-button slot="trigger" class="pf-m-primary">
-                        {% trans 'Create' %}
-                    </ak-spinner-button>
-                    <div slot="modal"></div>
-                </ak-modal-button>
-            </div>
-            {% include 'partials/pagination.html' %}
-        </div>
-    </div>
-    <table class="pf-c-table pf-m-compact pf-m-grid-xl" role="grid">
-        <thead>
-            <tr role="row">
-                <th role="columnheader" scope="col">{% trans 'Identifier' %}</th>
-                <th role="columnheader" scope="col">{% trans 'Expires?' %}</th>
-                <th role="columnheader" scope="col">{% trans 'Expiry Date' %}</th>
-                <th role="columnheader" scope="col">{% trans 'Description' %}</th>
-                <th role="cell"></th>
-            </tr>
-        </thead>
-        <tbody role="rowgroup">
-            {% for token in object_list %}
-            <tr role="row">
-                <th role="columnheader">
-                    <div>{{ token.identifier }}</div>
-                </th>
-                <td role="cell">
-                    <span>
-                        {{ token.expiring|yesno:"Yes,No" }}
-                    </span>
-                </td>
-                <td role="cell">
-                    <span>
-                        {% if not token.expiring %}
-                        -
-                        {% else %}
-                        {{ token.expires }}
-                        {% endif %}
-                    </span>
-                </td>
-                <td role="cell">
-                    <span>
-                        {{ token.description }}
-                    </span>
-                </td>
-                <td>
-                    <ak-modal-button href="{% url 'authentik_core:user-tokens-update' identifier=token.identifier %}">
-                        <ak-spinner-button slot="trigger" class="pf-m-secondary">
-                            {% trans 'Edit' %}
-                        </ak-spinner-button>
-                        <div slot="modal"></div>
-                    </ak-modal-button>
-                    <ak-modal-button href="{% url 'authentik_core:user-tokens-delete' identifier=token.identifier %}">
-                        <ak-spinner-button slot="trigger" class="pf-m-danger">
-                            {% trans 'Delete' %}
-                        </ak-spinner-button>
-                        <div slot="modal"></div>
-                    </ak-modal-button>
-                    <ak-token-copy-button identifier="{{ token.identifier }}">
-                        {% trans 'Copy token' %}
-                    </ak-token-copy-button>
-                </td>
-            </tr>
-            {% endfor %}
-        </tbody>
-    </table>
-    <div class="pf-c-pagination pf-m-bottom">
-        {% include 'partials/pagination.html' %}
-    </div>
-    {% else %}
-    <div class="pf-c-empty-state">
-        <div class="pf-c-empty-state__content">
-            <i class="fas fa-cubes pf-c-empty-state__icon" aria-hidden="true"></i>
-            <h1 class="pf-c-title pf-m-lg">
-                {% trans 'No Tokens.' %}
-            </h1>
-            <div class="pf-c-empty-state__body">
-                {% trans 'Currently no tokens exist. Click the button below to create one.' %}
-            </div>
-            <ak-modal-button href="{% url 'authentik_core:user-tokens-create' %}">
-                <ak-spinner-button slot="trigger" class="pf-m-primary">
-                    {% trans 'Create' %}
-                </ak-spinner-button>
-                <div slot="modal"></div>
-            </ak-modal-button>
-        </div>
-    </div>
-    {% endif %}
-</div>
diff --git a/authentik/core/urls.py b/authentik/core/urls.py
index f24a27e69..e51c01e68 100644
--- a/authentik/core/urls.py
+++ b/authentik/core/urls.py
@@ -1,7 +1,7 @@
 """authentik URL Configuration"""
 from django.urls import path
 
-from authentik.core.views import impersonate, library, shell, user
+from authentik.core.views import impersonate, shell, user
 
 urlpatterns = [
     path("", shell.ShellView.as_view(), name="shell"),
@@ -23,8 +23,6 @@ urlpatterns = [
         user.TokenDeleteView.as_view(),
         name="user-tokens-delete",
     ),
-    # Libray
-    path("library", library.LibraryView.as_view(), name="overview"),
     # Impersonation
     path(
         "-/impersonation/<int:user_id>/",
diff --git a/authentik/core/views/library.py b/authentik/core/views/library.py
deleted file mode 100644
index 0d7984cfc..000000000
--- a/authentik/core/views/library.py
+++ /dev/null
@@ -1,23 +0,0 @@
-"""authentik library view"""
-
-from django.contrib.auth.mixins import LoginRequiredMixin
-from django.views.generic import TemplateView
-
-from authentik.core.models import Application
-from authentik.policies.engine import PolicyEngine
-
-
-class LibraryView(LoginRequiredMixin, TemplateView):
-    """Overview for logged in user, incase user opens authentik directly
-    and is not being forwarded"""
-
-    template_name = "library.html"
-
-    def get_context_data(self, **kwargs):
-        kwargs["applications"] = []
-        for application in Application.objects.all().order_by("name"):
-            engine = PolicyEngine(application, self.request.user, self.request)
-            engine.build()
-            if engine.passing:
-                kwargs["applications"].append(application)
-        return super().get_context_data(**kwargs)
diff --git a/authentik/flows/stage.py b/authentik/flows/stage.py
index ade60ba89..6fd2d783e 100644
--- a/authentik/flows/stage.py
+++ b/authentik/flows/stage.py
@@ -65,7 +65,8 @@ class ChallengeStageView(StageView):
 
     def get(self, request: HttpRequest, *args, **kwargs) -> HttpResponse:
         challenge = self.get_challenge(*args, **kwargs)
-        challenge.initial_data["title"] = self.executor.flow.title
+        if "title" not in challenge.initial_data:
+            challenge.initial_data["title"] = self.executor.flow.title
         if not challenge.is_valid():
             LOGGER.warning(challenge.errors)
         return HttpChallengeResponse(challenge)
diff --git a/authentik/stages/identification/tests.py b/authentik/stages/identification/tests.py
index 8916d3b24..ccda61683 100644
--- a/authentik/stages/identification/tests.py
+++ b/authentik/stages/identification/tests.py
@@ -103,7 +103,7 @@ class TestIdentificationStage(TestCase):
         self.assertJSONEqual(
             force_str(response.content),
             {
-                "type": ChallengeTypes.native,
+                "type": ChallengeTypes.native.value,
                 "component": "ak-stage-identification",
                 "input_type": "email",
                 "enroll_url": "/flows/unique-enrollment-string/",
@@ -142,7 +142,7 @@ class TestIdentificationStage(TestCase):
         self.assertJSONEqual(
             force_str(response.content),
             {
-                "type": ChallengeTypes.native,
+                "type": ChallengeTypes.native.value,
                 "component": "ak-stage-identification",
                 "input_type": "email",
                 "recovery_url": "/flows/unique-recovery-string/",
diff --git a/web/src/elements/stages/autosubmit/AutosubmitStage.ts b/web/src/elements/stages/autosubmit/AutosubmitStage.ts
index c3d524d77..0c161f765 100644
--- a/web/src/elements/stages/autosubmit/AutosubmitStage.ts
+++ b/web/src/elements/stages/autosubmit/AutosubmitStage.ts
@@ -21,7 +21,7 @@ export class AutosubmitStage extends BaseStage {
     }
 
     updated(): void {
-        this.shadowRoot?.querySelectorAll("form").forEach((form) => {form.submit()});
+        this.shadowRoot?.querySelectorAll("form").forEach((form) => {form.submit();});
     }
 
     render(): TemplateResult {