From e4c251a1783a1c120907211f158fa55ea2fd7573 Mon Sep 17 00:00:00 2001 From: "gcp-cherry-pick-bot[bot]" <98988430+gcp-cherry-pick-bot[bot]@users.noreply.github.com> Date: Fri, 3 Nov 2023 13:17:26 +0100 Subject: [PATCH] web/admin: fix html error on oauth2 provider page (cherry-pick #7384) (#7424) web/admin: fix html error on oauth2 provider page (#7384) * web: break circular dependency between AKElement & Interface. This commit changes the way the root node of the web application shell is discovered by child components, such that the base class shared by both no longer results in a circular dependency between the two models. I've run this in isolation and have seen no failures of discovery; the identity token exists as soon as the Interface is constructed and is found by every item on the page. * web: fix broken typescript references This built... and then it didn't? Anyway, the current fix is to provide type information the AkInterface for the data that consumers require. * \# Details Extra `>` symbol screwed up the reading of the rest of the component. Unfortunately, too many fields in an input are optional, so it was easy for this bug to bypass any checks by the validators. I should have caught it myself, though. Co-authored-by: Ken Sternberg <133134217+kensternberg-authentik@users.noreply.github.com> --- web/src/admin/providers/oauth2/OAuth2ProviderForm.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/web/src/admin/providers/oauth2/OAuth2ProviderForm.ts b/web/src/admin/providers/oauth2/OAuth2ProviderForm.ts index c98ae860f..f5b59efe5 100644 --- a/web/src/admin/providers/oauth2/OAuth2ProviderForm.ts +++ b/web/src/admin/providers/oauth2/OAuth2ProviderForm.ts @@ -334,13 +334,14 @@ export class OAuth2ProviderFormPage extends ModelForm { )} > - + + )} + >