trustchain-oc1-orchestral/authentik
Archived
10
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

lib: test edgecase for timedelta_from_string

Browse source
This commit is contained in:
Jens Langhammer 2020-12-13 18:35:51 +01:00
parent 1c0a6efeb1
commit f056b026d6
4 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

0
authentik/lib/tests/__init__.py Normal file
View file

0
authentik/lib/tests.py → authentik/lib/tests/test_serializer_model.py
View file

2
authentik/providers/saml/tests/test_utils_time.py → authentik/lib/tests/test_utils_time.py
View file

@ -20,6 +20,8 @@ class TestTimeUtils(TestCase):
"""Test invalid expression""" """Test invalid expression"""
with self.assertRaises(ValueError): with self.assertRaises(ValueError):
timedelta_from_string("foo") timedelta_from_string("foo")
with self.assertRaises(ValueError):
timedelta_from_string("bar=baz")
def test_validation(self): def test_validation(self):
"""Test Django model field validator""" """Test Django model field validator"""

2
authentik/lib/utils/time.py
View file

@ -35,4 +35,6 @@ def timedelta_from_string(expr: str) -> datetime.timedelta:
if key.lower() not in ALLOWED_KEYS: if key.lower() not in ALLOWED_KEYS:
continue continue
kwargs[key.lower()] = float(value) kwargs[key.lower()] = float(value)
if len(kwargs) < 1:
raise ValueError("No valid keys to pass to timedelta")
return datetime.timedelta(**kwargs) return datetime.timedelta(**kwargs)