From 1a6afe29d32fd415ea251402854ede8af5e6b7b2 Mon Sep 17 00:00:00 2001 From: Cayo Puigdefabregas Date: Thu, 23 Jul 2020 19:20:53 +0200 Subject: [PATCH] bugfix tag test with cli --- ereuse_devicehub/resources/tag/__init__.py | 1 + tests/test_tag.py | 10 +++++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/ereuse_devicehub/resources/tag/__init__.py b/ereuse_devicehub/resources/tag/__init__.py index 1d8c75b2..e6418e54 100644 --- a/ereuse_devicehub/resources/tag/__init__.py +++ b/ereuse_devicehub/resources/tag/__init__.py @@ -66,6 +66,7 @@ class TagDef(Resource): ))) db.session.commit() + @option('-u', '--owner', help=OWNER_H) @option('--org', help=ORG_H) @option('--provider', help=PROV_H) @argument('path', type=cli.Path(writable=True)) diff --git a/tests/test_tag.py b/tests/test_tag.py index 4cc65e67..82a643b3 100644 --- a/tests/test_tag.py +++ b/tests/test_tag.py @@ -147,8 +147,9 @@ def test_tag_get_device_from_tag_endpoint_multiple_tags(app: Devicehub, user: Us @pytest.mark.mvp def test_tag_create_tags_cli(app: Devicehub, user: UserClient): """Checks creating tags with the CLI endpoint.""" + owner_id = user.user['id'] runner = app.test_cli_runner() - runner.invoke('tag', 'add', 'id1') + runner.invoke('tag', 'add', 'id1', '-u', owner_id) with app.app_context(): tag = Tag.query.one() # type: Tag assert tag.id == 'id1' @@ -159,8 +160,10 @@ def test_tag_create_tags_cli(app: Devicehub, user: UserClient): def test_tag_create_etags_cli(app: Devicehub, user: UserClient): """Creates an eTag through the CLI.""" # todo what happens to organization? + owner_id = user.user['id'] runner = app.test_cli_runner() - runner.invoke('tag', 'add', '-p', 'https://t.ereuse.org', '-s', 'foo', 'DT-BARBAR') + args = ('tag', 'add', '-p', 'https://t.ereuse.org', '-s', 'foo', 'DT-BARBAR', '-u', owner_id) + runner.invoke(*args) with app.app_context(): tag = Tag.query.one() # type: Tag assert tag.id == 'dt-barbar' @@ -234,9 +237,10 @@ def test_tag_secondary_workbench_link_find(user: UserClient): @pytest.mark.mvp def test_tag_create_tags_cli_csv(app: Devicehub, user: UserClient): """Checks creating tags with the CLI endpoint using a CSV.""" + owner_id = user.user['id'] csv = pathlib.Path(__file__).parent / 'files' / 'tags-cli.csv' runner = app.test_cli_runner() - runner.invoke('tag', 'add-csv', str(csv)) + runner.invoke('tag', 'add-csv', str(csv), '-u', owner_id) with app.app_context(): t1 = Tag.from_an_id('id1').one() t2 = Tag.from_an_id('sec1').one()