From f79abb05cd2b4c39c8da653ccc6044924d560a82 Mon Sep 17 00:00:00 2001
From: Cayo Puigdefabregas <cayo@ribaguifi.com>
Date: Thu, 3 Feb 2022 10:50:36 +0100
Subject: [PATCH 01/10] isort

---
 ereuse_devicehub/inventory/forms.py | 35 +++++++++++++++++------------
 ereuse_devicehub/inventory/views.py | 18 +++++++++------
 2 files changed, 32 insertions(+), 21 deletions(-)

diff --git a/ereuse_devicehub/inventory/forms.py b/ereuse_devicehub/inventory/forms.py
index 83efbd89..89c8c835 100644
--- a/ereuse_devicehub/inventory/forms.py
+++ b/ereuse_devicehub/inventory/forms.py
@@ -1,24 +1,31 @@
 import json
-from flask_wtf import FlaskForm
-from wtforms import StringField, validators, MultipleFileField, FloatField, IntegerField, \
-                    HiddenField, DateField, TextAreaField, SelectField
-from flask import g, request
-from sqlalchemy.util import OrderedSet
 from json.decoder import JSONDecodeError
 
+from flask import g, request
+from flask_wtf import FlaskForm
+from sqlalchemy.util import OrderedSet
+from wtforms import (DateField, FloatField, HiddenField, IntegerField,
+                     MultipleFileField, SelectField, StringField,
+                     TextAreaField, validators)
+
 from ereuse_devicehub.db import db
-from ereuse_devicehub.resources.device.models import Device, Computer, Smartphone, Cellphone, \
-                                                     Tablet, Monitor, Mouse, Keyboard, \
-                                                     MemoryCardReader, SAI
-from ereuse_devicehub.resources.action.models import Action, RateComputer, Snapshot, VisualTest
-from ereuse_devicehub.resources.action.schemas import Snapshot as SnapshotSchema
+from ereuse_devicehub.resources.action.models import (Action, RateComputer,
+                                                      Snapshot, VisualTest)
+from ereuse_devicehub.resources.action.rate.v1_0 import CannotRate
+from ereuse_devicehub.resources.action.schemas import \
+    Snapshot as SnapshotSchema
+from ereuse_devicehub.resources.action.views.snapshot import (move_json,
+                                                              save_json)
+from ereuse_devicehub.resources.device.models import (SAI, Cellphone, Computer,
+                                                      Device, Keyboard,
+                                                      MemoryCardReader,
+                                                      Monitor, Mouse,
+                                                      Smartphone, Tablet)
+from ereuse_devicehub.resources.device.sync import Sync
+from ereuse_devicehub.resources.enums import Severity, SnapshotSoftware
 from ereuse_devicehub.resources.lot.models import Lot
 from ereuse_devicehub.resources.tag.model import Tag
-from ereuse_devicehub.resources.enums import SnapshotSoftware, Severity
 from ereuse_devicehub.resources.user.exceptions import InsufficientPermission
-from ereuse_devicehub.resources.action.rate.v1_0 import CannotRate
-from ereuse_devicehub.resources.device.sync import Sync
-from ereuse_devicehub.resources.action.views.snapshot import save_json, move_json
 
 
 class LotDeviceForm(FlaskForm):
diff --git a/ereuse_devicehub/inventory/views.py b/ereuse_devicehub/inventory/views.py
index 29dcc78f..70dd5e53 100644
--- a/ereuse_devicehub/inventory/views.py
+++ b/ereuse_devicehub/inventory/views.py
@@ -1,14 +1,18 @@
-import flask
 import datetime
-from flask.views import View
-from flask import Blueprint, url_for, request
-from flask_login import login_required, current_user
 
+import flask
+from flask import Blueprint, request, url_for
+from flask.views import View
+from flask_login import current_user, login_required
+
+from ereuse_devicehub.inventory.forms import (AllocateForm, LotDeviceForm,
+                                              LotForm, NewActionForm,
+                                              NewDeviceForm, TagDeviceForm,
+                                              TagForm, TagUnnamedForm,
+                                              UploadSnapshotForm)
+from ereuse_devicehub.resources.device.models import Device
 from ereuse_devicehub.resources.lot.models import Lot
 from ereuse_devicehub.resources.tag.model import Tag
-from ereuse_devicehub.resources.device.models import Device
-from ereuse_devicehub.inventory.forms import LotDeviceForm, LotForm, UploadSnapshotForm, \
-    NewDeviceForm, TagForm, TagUnnamedForm, TagDeviceForm, NewActionForm, AllocateForm
 
 # TODO(@slamora): rename base 'inventory.devices' --> 'inventory'
 devices = Blueprint('inventory.devices', __name__, url_prefix='/inventory')

From e8b5c1e310bfa9e53ce83a8ba5d79025fcabe40e Mon Sep 17 00:00:00 2001
From: Cayo Puigdefabregas <cayo@ribaguifi.com>
Date: Thu, 3 Feb 2022 10:51:48 +0100
Subject: [PATCH 02/10] deactive dataWipe action

---
 ereuse_devicehub/templates/inventory/device_list.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ereuse_devicehub/templates/inventory/device_list.html b/ereuse_devicehub/templates/inventory/device_list.html
index df849ba9..ead573bf 100644
--- a/ereuse_devicehub/templates/inventory/device_list.html
+++ b/ereuse_devicehub/templates/inventory/device_list.html
@@ -139,7 +139,7 @@
                   </a>
                 </li>
                 <li>
-                  <a href="javascript:newAction('DataWipe')" class="dropdown-item">
+                  <a href="javascript:void()" class="dropdown-item">
                     <i class="bi bi-eraser-fill"></i>
                     DataWipe
                   </a>

From 820078dd3f3ecb43dc13cea91653976a9aecb75d Mon Sep 17 00:00:00 2001
From: Cayo Puigdefabregas <cayo@ribaguifi.com>
Date: Thu, 3 Feb 2022 11:44:51 +0100
Subject: [PATCH 03/10] UX: inform user about the type action thas is going to
 be created --> show type of action

---
 ereuse_devicehub/static/js/main_inventory.js       | 2 ++
 ereuse_devicehub/templates/inventory/actions.html  | 2 +-
 ereuse_devicehub/templates/inventory/allocate.html | 2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/ereuse_devicehub/static/js/main_inventory.js b/ereuse_devicehub/static/js/main_inventory.js
index c2fa6f8f..32067cbc 100644
--- a/ereuse_devicehub/static/js/main_inventory.js
+++ b/ereuse_devicehub/static/js/main_inventory.js
@@ -52,10 +52,12 @@ function removeTag() {
 
 function newAction(action) {
     $("#actionModal #type").val(action);
+    $("#actionModal #title-action").html(action);
     $("#activeActionModal").click();
 }
 
 function newAllocate(action) {
     $("#allocateModal #type").val(action);
+    $("#allocateModal #title-action").html(action);
     $("#activeAllocateModal").click();
 }
diff --git a/ereuse_devicehub/templates/inventory/actions.html b/ereuse_devicehub/templates/inventory/actions.html
index 61a942c5..2e14f24d 100644
--- a/ereuse_devicehub/templates/inventory/actions.html
+++ b/ereuse_devicehub/templates/inventory/actions.html
@@ -3,7 +3,7 @@
     <div class="modal-content">
 
       <div class="modal-header">
-        <h5 class="modal-title">New Action</h5>
+        <h5 class="modal-title">New Action <span id="title-action"></span></h5>
         <button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button>
       </div>
 
diff --git a/ereuse_devicehub/templates/inventory/allocate.html b/ereuse_devicehub/templates/inventory/allocate.html
index 0093e9b5..36f44cef 100644
--- a/ereuse_devicehub/templates/inventory/allocate.html
+++ b/ereuse_devicehub/templates/inventory/allocate.html
@@ -4,7 +4,7 @@
     <div class="modal-content">
 
       <div class="modal-header">
-        <h5 class="modal-title">New Action Allocate/Deallocate</h5>
+        <h5 class="modal-title">New Action <span id="title-action"></span></h5>
         <button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button>
       </div>
 

From aeef04b92c61c0e3fea64ac95582d9b0160f772e Mon Sep 17 00:00:00 2001
From: Cayo Puigdefabregas <cayo@ribaguifi.com>
Date: Thu, 3 Feb 2022 11:53:18 +0100
Subject: [PATCH 04/10] change modal-fullscreen by modal-lg

---
 ereuse_devicehub/templates/inventory/actions.html  | 2 +-
 ereuse_devicehub/templates/inventory/allocate.html | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ereuse_devicehub/templates/inventory/actions.html b/ereuse_devicehub/templates/inventory/actions.html
index 2e14f24d..e823f2aa 100644
--- a/ereuse_devicehub/templates/inventory/actions.html
+++ b/ereuse_devicehub/templates/inventory/actions.html
@@ -1,5 +1,5 @@
 <div class="modal fade" id="actionModal" tabindex="-1" style="display: none;" aria-hidden="true">
-  <div class="modal-dialog modal-fullscreen">
+  <div class="modal-dialog modal-lg">
     <div class="modal-content">
 
       <div class="modal-header">
diff --git a/ereuse_devicehub/templates/inventory/allocate.html b/ereuse_devicehub/templates/inventory/allocate.html
index 36f44cef..69cce7e0 100644
--- a/ereuse_devicehub/templates/inventory/allocate.html
+++ b/ereuse_devicehub/templates/inventory/allocate.html
@@ -1,6 +1,6 @@
 <div class="modal fade" id="allocateModal" tabindex="-1" style="display: none;" aria-hidden="true"
     data-show-action-form="{{ form_new_allocate.type.data }}">
-  <div class="modal-dialog modal-fullscreen">
+  <div class="modal-dialog modal-lg">
     <div class="modal-content">
 
       <div class="modal-header">

From 7f9a6784e9c69ae448326d28ee14993ed7a1335f Mon Sep 17 00:00:00 2001
From: Cayo Puigdefabregas <cayo@ribaguifi.com>
Date: Thu, 3 Feb 2022 13:58:54 +0100
Subject: [PATCH 05/10] add count of devices in action form

---
 ereuse_devicehub/static/js/main_inventory.js      | 14 +++++++++++++-
 ereuse_devicehub/templates/inventory/actions.html | 11 ++++++++---
 2 files changed, 21 insertions(+), 4 deletions(-)

diff --git a/ereuse_devicehub/static/js/main_inventory.js b/ereuse_devicehub/static/js/main_inventory.js
index 32067cbc..2478a420 100644
--- a/ereuse_devicehub/static/js/main_inventory.js
+++ b/ereuse_devicehub/static/js/main_inventory.js
@@ -11,15 +11,23 @@ $(document).ready(function() {
 
 function deviceSelect() {
     var devices = $(".deviceSelect").filter(':checked');
+    var devices_count = devices.length;
     var devices_id = $.map(devices, function(x) { return $(x).attr('data')}).join(",");
-    if (devices_id == "") {
+    if (devices_count == 0) {
         $("#addingLotModal .text-danger").show();
         $("#addingLotModal .btn-primary").hide();
 
         $("#removeLotModal .text-danger").show();
         $("#removeLotModal .btn-primary").hide();
+
         $("#addingTagModal .text-danger").show();
         $("#addingTagModal .btn-primary").hide();
+
+        $("#actionModal .text-danger").show();
+        $("#actionModal .btn-primary").hide();
+
+        $("#allocateModal .text-danger").show();
+        $("#allocateModal .btn-primary").hide();
     } else {
         $("#addingLotModal .text-danger").hide();
         $("#addingLotModal .btn-primary").show();
@@ -53,11 +61,15 @@ function removeTag() {
 function newAction(action) {
     $("#actionModal #type").val(action);
     $("#actionModal #title-action").html(action);
+    devices_count = $(".deviceSelect").filter(':checked').length;
+    $("#actionModal .devices-count").html(devices_count);
     $("#activeActionModal").click();
 }
 
 function newAllocate(action) {
     $("#allocateModal #type").val(action);
     $("#allocateModal #title-action").html(action);
+    devices_count = $(".deviceSelect").filter(':checked').length;
+    $("#actionModal .devices-count").html(devices_count);
     $("#activeAllocateModal").click();
 }
diff --git a/ereuse_devicehub/templates/inventory/actions.html b/ereuse_devicehub/templates/inventory/actions.html
index e823f2aa..c74afa41 100644
--- a/ereuse_devicehub/templates/inventory/actions.html
+++ b/ereuse_devicehub/templates/inventory/actions.html
@@ -10,12 +10,17 @@
       <form action="{{ url_for('inventory.devices.action_add') }}" method="post">
       {{ form_new_action.csrf_token }}
         <div class="modal-body">
-          <p class="text-danger">
-              You need select first some device before to do one action
-          </p>
           {% for field in form_new_action %}
           {% if field != form_new_action.csrf_token %}
           {% if field == form_new_action.devices  %}
+          <div class="col-12">
+              {{ field.label(class_="form-label") }}: <span class="devices-count"></span>
+              {{ field(class_="form-control") }}
+              <p class="text-danger">
+                  You need select first some device before to do one action
+              </p>
+              <p class="enumeration-devices"></p>
+          </div>
           {{ field(class_="devicesList") }}
           {% elif field == form_new_action.type %}
             {{ field(class_="form-control") }}

From c10a5f24b42ff3f0c7ea283fadb5af0b48a58204 Mon Sep 17 00:00:00 2001
From: Cayo Puigdefabregas <cayo@ribaguifi.com>
Date: Thu, 3 Feb 2022 14:05:15 +0100
Subject: [PATCH 06/10] add count to allocate action

---
 ereuse_devicehub/static/js/main_inventory.js       | 6 +++---
 ereuse_devicehub/templates/inventory/actions.html  | 3 +--
 ereuse_devicehub/templates/inventory/allocate.html | 9 ++++++++-
 3 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/ereuse_devicehub/static/js/main_inventory.js b/ereuse_devicehub/static/js/main_inventory.js
index 2478a420..48834647 100644
--- a/ereuse_devicehub/static/js/main_inventory.js
+++ b/ereuse_devicehub/static/js/main_inventory.js
@@ -61,7 +61,7 @@ function removeTag() {
 function newAction(action) {
     $("#actionModal #type").val(action);
     $("#actionModal #title-action").html(action);
-    devices_count = $(".deviceSelect").filter(':checked').length;
+    var devices_count = $(".deviceSelect").filter(':checked').length;
     $("#actionModal .devices-count").html(devices_count);
     $("#activeActionModal").click();
 }
@@ -69,7 +69,7 @@ function newAction(action) {
 function newAllocate(action) {
     $("#allocateModal #type").val(action);
     $("#allocateModal #title-action").html(action);
-    devices_count = $(".deviceSelect").filter(':checked').length;
-    $("#actionModal .devices-count").html(devices_count);
+    var devices_count = $(".deviceSelect").filter(':checked').length;
+    $("#allocateModal .devices-count").html(devices_count);
     $("#activeAllocateModal").click();
 }
diff --git a/ereuse_devicehub/templates/inventory/actions.html b/ereuse_devicehub/templates/inventory/actions.html
index c74afa41..e66d46cc 100644
--- a/ereuse_devicehub/templates/inventory/actions.html
+++ b/ereuse_devicehub/templates/inventory/actions.html
@@ -15,13 +15,12 @@
           {% if field == form_new_action.devices  %}
           <div class="col-12">
               {{ field.label(class_="form-label") }}: <span class="devices-count"></span>
-              {{ field(class_="form-control") }}
+              {{ field(class_="devicesList") }}
               <p class="text-danger">
                   You need select first some device before to do one action
               </p>
               <p class="enumeration-devices"></p>
           </div>
-          {{ field(class_="devicesList") }}
           {% elif field == form_new_action.type %}
             {{ field(class_="form-control") }}
           {% else %}
diff --git a/ereuse_devicehub/templates/inventory/allocate.html b/ereuse_devicehub/templates/inventory/allocate.html
index 69cce7e0..a51c3d6a 100644
--- a/ereuse_devicehub/templates/inventory/allocate.html
+++ b/ereuse_devicehub/templates/inventory/allocate.html
@@ -22,7 +22,14 @@
           {% for field in form_new_allocate %}
           {% if field != form_new_allocate.csrf_token %}
           {% if field == form_new_allocate.devices  %}
-          {{ field(class_="devicesList") }}
+          <div class="col-12">
+              {{ field.label(class_="form-label") }}: <span class="devices-count"></span>
+              {{ field(class_="devicesList") }}
+              <p class="text-danger">
+                  You need select first some device before to do one action
+              </p>
+              <p class="enumeration-devices"></p>
+          </div>
           {% elif field == form_new_allocate.type %}
             {{ field(class_="form-control") }}
           {% else %}

From f011e29ce90d425463b89580a70b87ba4cec7be7 Mon Sep 17 00:00:00 2001
From: Cayo Puigdefabregas <cayo@ribaguifi.com>
Date: Fri, 4 Feb 2022 11:30:29 +0100
Subject: [PATCH 07/10] add description of device in actions

---
 ereuse_devicehub/static/js/main_inventory.js  | 46 +++++++++++++++----
 .../templates/inventory/device_list.html      |  6 ++-
 2 files changed, 41 insertions(+), 11 deletions(-)

diff --git a/ereuse_devicehub/static/js/main_inventory.js b/ereuse_devicehub/static/js/main_inventory.js
index 48834647..f1bb44eb 100644
--- a/ereuse_devicehub/static/js/main_inventory.js
+++ b/ereuse_devicehub/static/js/main_inventory.js
@@ -10,9 +10,7 @@ $(document).ready(function() {
 })
 
 function deviceSelect() {
-    var devices = $(".deviceSelect").filter(':checked');
-    var devices_count = devices.length;
-    var devices_id = $.map(devices, function(x) { return $(x).attr('data')}).join(",");
+    var devices_count = $(".deviceSelect").filter(':checked').length;
     if (devices_count == 0) {
         $("#addingLotModal .text-danger").show();
         $("#addingLotModal .btn-primary").hide();
@@ -43,9 +41,6 @@ function deviceSelect() {
 
         $("#addingTagModal .text-danger").hide();
     }
-    $.map($(".devicesList"), function(x) {
-        $(x).val(devices_id);
-    });
 }
 
 function removeTag() {
@@ -61,15 +56,46 @@ function removeTag() {
 function newAction(action) {
     $("#actionModal #type").val(action);
     $("#actionModal #title-action").html(action);
-    var devices_count = $(".deviceSelect").filter(':checked').length;
-    $("#actionModal .devices-count").html(devices_count);
+    get_device_list();
     $("#activeActionModal").click();
 }
 
 function newAllocate(action) {
     $("#allocateModal #type").val(action);
     $("#allocateModal #title-action").html(action);
-    var devices_count = $(".deviceSelect").filter(':checked').length;
-    $("#allocateModal .devices-count").html(devices_count);
+    get_device_list();
     $("#activeAllocateModal").click();
 }
+
+function get_device_list() {
+    var devices = $(".deviceSelect").filter(':checked');
+
+    /* Insert the correct count of devices in actions form */
+    var devices_count = devices.length;
+    $("#allocateModal .devices-count").html(devices_count);
+    $("#actionModal .devices-count").html(devices_count);
+
+    /* Insert the correct value in the input devicesList */
+    var devices_id = $.map(devices, function(x) { return $(x).attr('data')}).join(",");
+    $.map($(".devicesList"), function(x) {
+        $(x).val(devices_id);
+    });
+
+    /* Create a list of devices for human representation */
+    var computer = {
+        "Desktop": "<i class='bi bi-building'></i>",
+        "Laptop": "<i class='bi bi-laptop'></i>",
+    };
+    list_devices = devices.map(function (x) {
+        var typ = $(devices[x]).data("device-type");
+        var manuf = $(devices[x]).data("device-manufacturer");
+        var dhid = $(devices[x]).data("device-dhid");
+        if (computer[typ]) {
+            typ = computer[typ];
+        };
+        return typ + " " + manuf + " " + dhid;
+    });
+
+    description = $.map(list_devices, function(x) { return x }).join(", ");
+    $(".enumeration-devices").html(description);
+}
diff --git a/ereuse_devicehub/templates/inventory/device_list.html b/ereuse_devicehub/templates/inventory/device_list.html
index ead573bf..0c898246 100644
--- a/ereuse_devicehub/templates/inventory/device_list.html
+++ b/ereuse_devicehub/templates/inventory/device_list.html
@@ -234,7 +234,11 @@
                   <tbody>
                     {% for dev in devices %}
                     <tr>
-                      <td><input type="checkbox" class="deviceSelect" data="{{ dev.id }}"/></td>
+                      <td>
+                          <input type="checkbox" class="deviceSelect" data="{{ dev.id }}"
+                               data-device-type="{{ dev.type }}" data-device-manufacturer="{{ dev.manufacturer }}"
+                               data-device-dhid="{{ dev.devicehub_id }}" />
+                      </td>
                       <td>
                         <a href="{{ url_for('inventory.devices.device_details', id=dev.devicehub_id)}}">
                           {{ dev.type }} {{ dev.manufacturer }} {{ dev.model }}

From 662f75bb7bb28f74226608c85ea5c18dffd7a6b1 Mon Sep 17 00:00:00 2001
From: Cayo Puigdefabregas <cayo@ribaguifi.com>
Date: Fri, 4 Feb 2022 12:10:27 +0100
Subject: [PATCH 08/10] refactoring and put again the lot in form of actions

---
 ereuse_devicehub/inventory/forms.py                |  1 +
 ereuse_devicehub/inventory/views.py                | 13 +++++++++----
 ereuse_devicehub/templates/inventory/actions.html  |  4 +++-
 ereuse_devicehub/templates/inventory/allocate.html | 11 ++++-------
 4 files changed, 17 insertions(+), 12 deletions(-)

diff --git a/ereuse_devicehub/inventory/forms.py b/ereuse_devicehub/inventory/forms.py
index 89c8c835..e9430e63 100644
--- a/ereuse_devicehub/inventory/forms.py
+++ b/ereuse_devicehub/inventory/forms.py
@@ -477,6 +477,7 @@ class NewActionForm(FlaskForm):
     date = DateField(u'Date', validators=(validators.Optional(),))
     severity = SelectField(u'Severity', choices=[(v.name, v.name) for v in Severity])
     description = TextAreaField(u'Description')
+    lot = HiddenField()
     type = HiddenField()
 
     def validate(self, extra_validators=None):
diff --git a/ereuse_devicehub/inventory/views.py b/ereuse_devicehub/inventory/views.py
index 70dd5e53..83c0a09d 100644
--- a/ereuse_devicehub/inventory/views.py
+++ b/ereuse_devicehub/inventory/views.py
@@ -289,9 +289,14 @@ class NewActionView(View):
 
     def dispatch_request(self):
         self.form = self._form()
+
+        next_url = url_for('inventory.devices.devicelist')
+        lot_id = self.form.lot.data
+        if lot_id:
+            next_url = url_for('inventory.devices.lotdevicelist', lot_id=lot_id)
+
         if self.form.validate_on_submit():
             self.form.save()
-            next_url = request.referrer or url_for('inventory.devices.devicelist')
             return flask.redirect(next_url)
 
 
@@ -300,11 +305,13 @@ class NewAllocateView(NewActionView, DeviceListMix):
     _form = AllocateForm
 
     def dispatch_request(self, lot_id=None):
+        self.form = self._form()
+
         next_url = url_for('inventory.devices.devicelist')
+        lot_id = self.form.lot.data
         if lot_id:
             next_url = url_for('inventory.devices.lotdevicelist', lot_id=lot_id)
 
-        self.form = self._form()
         if self.form.validate_on_submit():
             self.form.save()
             return flask.redirect(next_url)
@@ -316,8 +323,6 @@ class NewAllocateView(NewActionView, DeviceListMix):
 
 devices.add_url_rule('/action/add/', view_func=NewActionView.as_view('action_add'))
 devices.add_url_rule('/action/allocate/add/', view_func=NewAllocateView.as_view('allocate_add'))
-devices.add_url_rule('/lot/<string:lot_id>/action/allocate/add/',
-                          view_func=NewAllocateView.as_view('lot_allocate_add'))
 devices.add_url_rule('/device/', view_func=DeviceListView.as_view('devicelist'))
 devices.add_url_rule('/device/<string:id>/', view_func=DeviceDetailView.as_view('device_details'))
 devices.add_url_rule('/lot/<string:lot_id>/device/', view_func=DeviceListView.as_view('lotdevicelist'))
diff --git a/ereuse_devicehub/templates/inventory/actions.html b/ereuse_devicehub/templates/inventory/actions.html
index e66d46cc..14230437 100644
--- a/ereuse_devicehub/templates/inventory/actions.html
+++ b/ereuse_devicehub/templates/inventory/actions.html
@@ -21,8 +21,10 @@
               </p>
               <p class="enumeration-devices"></p>
           </div>
+          {% elif field == form_new_action.lot %}
+            {{ field }}
           {% elif field == form_new_action.type %}
-            {{ field(class_="form-control") }}
+            {{ field }}
           {% else %}
           <div class="col-12">
               {{ field.label(class_="form-label") }}
diff --git a/ereuse_devicehub/templates/inventory/allocate.html b/ereuse_devicehub/templates/inventory/allocate.html
index a51c3d6a..71bfc0b6 100644
--- a/ereuse_devicehub/templates/inventory/allocate.html
+++ b/ereuse_devicehub/templates/inventory/allocate.html
@@ -8,12 +8,7 @@
         <button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button>
       </div>
 
-      <form action="
-      {% if lot %}
-          {{ url_for('inventory.devices.lot_allocate_add', lot_id=lot.id) }}
-      {% else %}
-          {{ url_for('inventory.devices.allocate_add') }}
-      {% endif %}" method="post">
+      <form action="{{ url_for('inventory.devices.allocate_add') }}" method="post">
       {{ form_new_allocate.csrf_token }}
         <div class="modal-body">
           <p class="text-danger" id="pol" style="display: none;">
@@ -30,8 +25,10 @@
               </p>
               <p class="enumeration-devices"></p>
           </div>
+          {% elif field == form_new_allocate.lot %}
+            {{ field }}
           {% elif field == form_new_allocate.type %}
-            {{ field(class_="form-control") }}
+            {{ field }}
           {% else %}
           <div class="col-12">
               {{ field.label(class_="form-label") }}

From a55944e379433cb2c099a6cede3fc1a7101a648e Mon Sep 17 00:00:00 2001
From: Cayo Puigdefabregas <cayo@ribaguifi.com>
Date: Fri, 4 Feb 2022 13:16:27 +0100
Subject: [PATCH 09/10] check the checkbox in a devices list when one form is
 invalid

---
 ereuse_devicehub/templates/inventory/actions.html          | 2 +-
 ereuse_devicehub/templates/inventory/addDeviceslot.html    | 2 +-
 ereuse_devicehub/templates/inventory/addDevicestag.html    | 2 +-
 ereuse_devicehub/templates/inventory/allocate.html         | 5 +----
 ereuse_devicehub/templates/inventory/device_list.html      | 6 +++++-
 ereuse_devicehub/templates/inventory/removeDeviceslot.html | 2 +-
 6 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/ereuse_devicehub/templates/inventory/actions.html b/ereuse_devicehub/templates/inventory/actions.html
index 14230437..f3fc4a7f 100644
--- a/ereuse_devicehub/templates/inventory/actions.html
+++ b/ereuse_devicehub/templates/inventory/actions.html
@@ -16,7 +16,7 @@
           <div class="col-12">
               {{ field.label(class_="form-label") }}: <span class="devices-count"></span>
               {{ field(class_="devicesList") }}
-              <p class="text-danger">
+              <p class="text-danger pol">
                   You need select first some device before to do one action
               </p>
               <p class="enumeration-devices"></p>
diff --git a/ereuse_devicehub/templates/inventory/addDeviceslot.html b/ereuse_devicehub/templates/inventory/addDeviceslot.html
index f489d28c..3a42cf00 100644
--- a/ereuse_devicehub/templates/inventory/addDeviceslot.html
+++ b/ereuse_devicehub/templates/inventory/addDeviceslot.html
@@ -17,7 +17,7 @@
             {% endfor %}
           </select>
           <input class="devicesList" type="hidden" name="devices" />
-          <p class="text-danger">
+          <p class="text-danger pol">
               You need select first some device for adding this in a lot
           </p>
         </div>
diff --git a/ereuse_devicehub/templates/inventory/addDevicestag.html b/ereuse_devicehub/templates/inventory/addDevicestag.html
index 03265569..9c157729 100644
--- a/ereuse_devicehub/templates/inventory/addDevicestag.html
+++ b/ereuse_devicehub/templates/inventory/addDevicestag.html
@@ -17,7 +17,7 @@
             {% endfor %}
           </select>
           <input class="devicesList" type="hidden" name="device" />
-          <p class="text-danger">
+          <p class="text-danger pol">
               You need select first some device for adding this in a tag
           </p>
         </div>
diff --git a/ereuse_devicehub/templates/inventory/allocate.html b/ereuse_devicehub/templates/inventory/allocate.html
index 71bfc0b6..fb16ce86 100644
--- a/ereuse_devicehub/templates/inventory/allocate.html
+++ b/ereuse_devicehub/templates/inventory/allocate.html
@@ -11,16 +11,13 @@
       <form action="{{ url_for('inventory.devices.allocate_add') }}" method="post">
       {{ form_new_allocate.csrf_token }}
         <div class="modal-body">
-          <p class="text-danger" id="pol" style="display: none;">
-              You need select first some device before to do one action
-          </p>
           {% for field in form_new_allocate %}
           {% if field != form_new_allocate.csrf_token %}
           {% if field == form_new_allocate.devices  %}
           <div class="col-12">
               {{ field.label(class_="form-label") }}: <span class="devices-count"></span>
               {{ field(class_="devicesList") }}
-              <p class="text-danger">
+              <p class="text-danger pol" style="display: none;">
                   You need select first some device before to do one action
               </p>
               <p class="enumeration-devices"></p>
diff --git a/ereuse_devicehub/templates/inventory/device_list.html b/ereuse_devicehub/templates/inventory/device_list.html
index 0c898246..97291791 100644
--- a/ereuse_devicehub/templates/inventory/device_list.html
+++ b/ereuse_devicehub/templates/inventory/device_list.html
@@ -237,7 +237,11 @@
                       <td>
                           <input type="checkbox" class="deviceSelect" data="{{ dev.id }}"
                                data-device-type="{{ dev.type }}" data-device-manufacturer="{{ dev.manufacturer }}"
-                               data-device-dhid="{{ dev.devicehub_id }}" />
+                               data-device-dhid="{{ dev.devicehub_id }}"
+                               {% if form_new_allocate.type.data and dev.id in list_devices %}
+                                 checked="checked"
+                               {% endif %}
+                               />
                       </td>
                       <td>
                         <a href="{{ url_for('inventory.devices.device_details', id=dev.devicehub_id)}}">
diff --git a/ereuse_devicehub/templates/inventory/removeDeviceslot.html b/ereuse_devicehub/templates/inventory/removeDeviceslot.html
index 31797cf3..1a00dabf 100644
--- a/ereuse_devicehub/templates/inventory/removeDeviceslot.html
+++ b/ereuse_devicehub/templates/inventory/removeDeviceslot.html
@@ -16,7 +16,7 @@
             {% endfor %}
           </select>
           <input class="devicesList" type="hidden" name="devices" />
-          <p class="text-danger">
+          <p class="text-danger pol">
               You need select first some device for remove this from a lot
           </p>
         </div>

From c340122d87dacf523085bdef171caed1fb5a67b2 Mon Sep 17 00:00:00 2001
From: Cayo Puigdefabregas <cayo@ribaguifi.com>
Date: Fri, 4 Feb 2022 13:22:47 +0100
Subject: [PATCH 10/10] check the checkbox in a devices list when one form is
 invalid 2

---
 ereuse_devicehub/inventory/views.py          |  8 ++++++-
 ereuse_devicehub/static/js/main_inventory.js | 22 +++++++++++---------
 2 files changed, 19 insertions(+), 11 deletions(-)

diff --git a/ereuse_devicehub/inventory/views.py b/ereuse_devicehub/inventory/views.py
index 83c0a09d..bd52eb77 100644
--- a/ereuse_devicehub/inventory/views.py
+++ b/ereuse_devicehub/inventory/views.py
@@ -45,6 +45,11 @@ class DeviceListMix(View):
             form_new_action = NewActionForm()
             form_new_allocate = AllocateForm()
 
+        action_devices = form_new_action.devices.data
+        list_devices = []
+        if action_devices:
+            list_devices.extend([int(x) for x in action_devices.split(",")])
+
         self.context = {
             'devices': devices,
             'lots': lots,
@@ -53,7 +58,8 @@ class DeviceListMix(View):
             'form_new_action': form_new_action,
             'form_new_allocate': form_new_allocate,
             'lot': lot,
-            'tags': tags
+            'tags': tags,
+            'list_devices': list_devices
         }
 
         return self.context
diff --git a/ereuse_devicehub/static/js/main_inventory.js b/ereuse_devicehub/static/js/main_inventory.js
index f1bb44eb..05833fe5 100644
--- a/ereuse_devicehub/static/js/main_inventory.js
+++ b/ereuse_devicehub/static/js/main_inventory.js
@@ -12,34 +12,34 @@ $(document).ready(function() {
 function deviceSelect() {
     var devices_count = $(".deviceSelect").filter(':checked').length;
     if (devices_count == 0) {
-        $("#addingLotModal .text-danger").show();
+        $("#addingLotModal .pol").show();
         $("#addingLotModal .btn-primary").hide();
 
-        $("#removeLotModal .text-danger").show();
+        $("#removeLotModal .pol").show();
         $("#removeLotModal .btn-primary").hide();
 
-        $("#addingTagModal .text-danger").show();
+        $("#addingTagModal .pol").show();
         $("#addingTagModal .btn-primary").hide();
 
-        $("#actionModal .text-danger").show();
+        $("#actionModal .pol").show();
         $("#actionModal .btn-primary").hide();
 
-        $("#allocateModal .text-danger").show();
+        $("#allocateModal .pol").show();
         $("#allocateModal .btn-primary").hide();
     } else {
-        $("#addingLotModal .text-danger").hide();
+        $("#addingLotModal .pol").hide();
         $("#addingLotModal .btn-primary").show();
 
-        $("#removeLotModal .text-danger").hide();
+        $("#removeLotModal .pol").hide();
         $("#removeLotModal .btn-primary").show();
 
-        $("#actionModal .text-danger").hide();
+        $("#actionModal .pol").hide();
         $("#actionModal .btn-primary").show();
 
-        $("#allocateModal .text-danger").hide();
+        $("#allocateModal .pol").hide();
         $("#allocateModal .btn-primary").show();
 
-        $("#addingTagModal .text-danger").hide();
+        $("#addingTagModal .pol").hide();
     }
 }
 
@@ -57,6 +57,7 @@ function newAction(action) {
     $("#actionModal #type").val(action);
     $("#actionModal #title-action").html(action);
     get_device_list();
+    deviceSelect();
     $("#activeActionModal").click();
 }
 
@@ -64,6 +65,7 @@ function newAllocate(action) {
     $("#allocateModal #type").val(action);
     $("#allocateModal #title-action").html(action);
     get_device_list();
+    deviceSelect();
     $("#activeAllocateModal").click();
 }