trustchain-oc1-orchestral
/
devicehub-teal
Archived
10
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Raise error if trying to save when validation has failed

This commit is contained in:
Santiago L 2022-02-22 12:04:26 +01:00
parent bacf14ece8
commit d4e61d992b
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
ereuse_devicehub/inventory/forms.py
View File

@ -732,7 +732,7 @@ class TradeForm(NewActionForm):
email_to = self.user_to.data email_to = self.user_to.data
if not self.confirm.data and not self.code.data: if not self.confirm.data and not self.code.data:
self.code.errors = ["If you don't want confirm, you need a code"] self.code.errors = ["If you don't want to confirm, you need a code"]
is_valid = False is_valid = False
if ( if (
@ -757,9 +757,15 @@ class TradeForm(NewActionForm):
self.db_user_to = user_to self.db_user_to = user_to
self.db_user_from = user_from self.db_user_from = user_from
self.has_errors = not is_valid
return is_valid return is_valid
def save(self, commit=True): def save(self, commit=True):
if self.has_errors:
raise ValueError(
"The %s could not be saved because the data didn't validate."
% (self.instance._meta.object_name)
)
if not self.confirm.data: if not self.confirm.data:
self.create_phantom_account() self.create_phantom_account()
self.prepare_instance() self.prepare_instance()
@ -794,11 +800,6 @@ class TradeForm(NewActionForm):
The same if exist to but not from The same if exist to but not from
""" """
# Checks
if self.code.data:
msg = "If you don't want confirm, you need a code"
return ValidationError(msg)
user_from = self.user_from.data user_from = self.user_from.data
user_to = self.user_to.data user_to = self.user_to.data
code = self.code.data code = self.code.data